fix(profiling): Handle potential attribute errors in profiler #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've noticed some edge cases where the api doesn't return the expected `FrameType` or is missing some attributes. There isn't much we can do about this other than to handle the error and drop the sample.
sl0thentr0py
approved these changes
Apr 25, 2023
Zylphrex
deleted the
txiao/fix/handle-potential-attribute-errors-in-profiler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've noticed some edge cases where the api doesn't return the expected
FrameTypeor is missing some attributes. There isn't much we can do about this other than to handle the error and drop the sample.Closes #2022