Skip to content

Capture GraphQL client errors #2243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 43 commits into from
Jul 20, 2023
Merged

Capture GraphQL client errors #2243

merged 43 commits into from
Jul 20, 2023

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jul 12, 2023 •
edited
Loading

Inspect requests done with our HTTP client integrations (stdlib, httpx, aiohttp), identify GraphQL requests, and capture a specialized error event if the response from the server contains a non-empty errors array.

Closes #2198

@sentrivana
Copy link
Contributor Author

Open question: should this be opt-in and hidden behind a client option?

antonpirker
antonpirker requested changes Jul 13, 2023
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Work @sentrivana !

@sentrivana sentrivana marked this pull request as ready for review July 14, 2023 15:31
@sentrivana sentrivana marked this pull request as draft July 14, 2023 15:33
@sentrivana sentrivana marked this pull request as ready for review July 17, 2023 15:03
@antonpirker antonpirker self-requested a review July 20, 2023 08:26
antonpirker
antonpirker reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 lgtm :shipit:

antonpirker
antonpirker approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now the right checkbox selected :-)

@antonpirker antonpirker enabled auto-merge (squash) July 20, 2023 08:27
@antonpirker antonpirker merged commit 5199d54 into master Jul 20, 2023
@antonpirker antonpirker deleted the ivana/graphql branch July 20, 2023 08:32
sentrivana added a commit that referenced this pull request Aug 1, 2023
@sentrivana
Revert "Capture GraphQL client errors (#2243)"
f2d10b1 
This reverts commit 5199d54.
sentrivana added a commit that referenced this pull request Aug 1, 2023
@sentrivana
Revert GraphQL integration (#2287)
691bced 
* Revert "Fix GraphQL integration swallowing responses (#2286)"

This reverts commit e918504.

* Revert "Capture GraphQL client errors (#2243)"

This reverts commit 5199d54.
@sentrivana sentrivana mentioned this pull request Aug 2, 2023
Closed
1 task
@vwrj vwrj mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQL Connected Services
2 participants
@sentrivana @antonpirker