Skip to content

docs(scope): Correct use_scope comment #2790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

szokeasaurusrex
Copy link
Member

The example in the use_scope comment appears to have been copied directly from the new_scope example verbatim.

This change fixes the example, so the example demonstrates how to call use_scope rather than how to call new_scope.

@antonpirker, please make sure that I got the usage in the example correct; I think this is how use_scope is used but I'm less than 100% sure.

@szokeasaurusrex szokeasaurusrex changed the title Correct use_scope comment docs(scope): Correct use_scope comment Mar 6, 2024
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@szokeasaurusrex szokeasaurusrex merged commit 406c68d into sentry-sdk-2.0 Mar 6, 2024
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/correct-use_scope-comment branch March 6, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants