-
Notifications
You must be signed in to change notification settings - Fork 553
Use a deeper copy for frame vars #3392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 19636 tests with View the full list of failed testspy3.10-common
py3.10-django-latest
py3.10-django-v5.0
py3.10-gevent
py3.11-asgi
py3.11-common
py3.11-django-latest
py3.11-django-v5.1
py3.11-falcon-latest
py3.11-gevent
py3.11-langchain-latest
py3.11-langchain-v0.1
py3.12-asgi
py3.12-common
py3.12-django-latest
py3.12-django-v5.1
py3.12-falcon-latest
py3.12-gevent
py3.12-langchain-latest
py3.12-langchain-notiktoken
py3.13-common
py3.6-common
py3.6-django-v3.2
py3.6-falcon-v3
py3.6-gevent
py3.6-pyramid-latest
py3.7-asgi
py3.7-common
py3.7-django-v2.0
py3.7-falcon-latest
py3.8-common
py3.8-django-v4.0
py3.8-gevent
py3.8-sanic-v20
py3.8-tornado-latest
py3.9-common
py3.9-django-v3.2
py3.9-langchain-latest
py3.9-langchain-v0.1
|
7ae3b1c
to
2db1b27
Compare
2db1b27
to
7d3bcc0
Compare
7d3bcc0
to
009d046
Compare
sentrivana
approved these changes
Aug 2, 2024
7f6f4ee
to
e8ba3c9
Compare
To make this work, I had to add a port of python's `copy.deepcopy` (license included) that falls back to `safe_repr` instead of the pickling step. This ensures that we have a deepcopy of all data structure like objects - dicts/lists/tuples and so on and we make a repr early for other random objects.
e8ba3c9
to
9e54be5
Compare
this is getting out of hand so i'm trying another solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added the
recursive
option for theEventScrubber
in #2755, vars nested inside could be replaced withAnnotatedValue
and potentially break userland code.We really shouldn't be holding references to
frame.f_locals
throughout our SDK, this has all sorts of breakage potential.To make this work, I had to add a port of python's
copy.deepcopy
(license included) that falls back tosafe_repr
instead of the pickling step. This ensures that we have a deepcopy of all data structure like objects - dicts/lists/tuples and so on while we make a repr early for other random objects.