-
Notifications
You must be signed in to change notification settings - Fork 552
[4] Move the Flags group over to the tox gen script #3974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4f0b90c
Add tox generation script, but don't use it yet
sentrivana c2c6450
add missing file
sentrivana 3ac285d
Add more min versions
sentrivana dd118e7
wip
sentrivana f26cab6
.
sentrivana 0f79331
Merge branch 'master' into ivana/tox-script-3
sentrivana c18d600
small fix
sentrivana c25c33f
Merge branch 'master' into ivana/tox-script-3
sentrivana 7eaf820
add statsig too
sentrivana 832ea71
add missing dep
sentrivana dca7270
Merge branch 'master' into ivana/tox-script-3
sentrivana ba74ec3
Merge branch 'master' into ivana/tox-script-3
sentrivana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,82 +22,14 @@ env: | |
| CACHED_BUILD_PATHS: | | ||
| ${{ github.workspace }}/dist-serverless | ||
| jobs: | ||
| test-flags-latest: | ||
| name: Flags (latest) | ||
| timeout-minutes: 30 | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.8","3.12","3.13"] | ||
| # python3.6 reached EOL and is no longer being supported on | ||
| # new versions of hosted runners on Github Actions | ||
| # ubuntu-20.04 is the last version that supported python3.6 | ||
| # see https://github.com/actions/setup-python/issues/544#issuecomment-1332535877 | ||
| os: [ubuntu-20.04] | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| allow-prereleases: true | ||
| - name: Setup Test Env | ||
| run: | | ||
| pip install "coverage[toml]" tox | ||
| - name: Erase coverage | ||
| run: | | ||
| coverage erase | ||
| - name: Test launchdarkly latest | ||
| run: | | ||
| set -x # print commands that are executed | ||
| ./scripts/runtox.sh "py${{ matrix.python-version }}-launchdarkly-latest" | ||
| - name: Test openfeature latest | ||
| run: | | ||
| set -x # print commands that are executed | ||
| ./scripts/runtox.sh "py${{ matrix.python-version }}-openfeature-latest" | ||
| - name: Test statsig latest | ||
| run: | | ||
| set -x # print commands that are executed | ||
| ./scripts/runtox.sh "py${{ matrix.python-version }}-statsig-latest" | ||
| - name: Test unleash latest | ||
| run: | | ||
| set -x # print commands that are executed | ||
| ./scripts/runtox.sh "py${{ matrix.python-version }}-unleash-latest" | ||
| - name: Generate coverage XML (Python 3.6) | ||
| if: ${{ !cancelled() && matrix.python-version == '3.6' }} | ||
| run: | | ||
| export COVERAGE_RCFILE=.coveragerc36 | ||
| coverage combine .coverage-sentry-* | ||
| coverage xml --ignore-errors | ||
| - name: Generate coverage XML | ||
| if: ${{ !cancelled() && matrix.python-version != '3.6' }} | ||
| run: | | ||
| coverage combine .coverage-sentry-* | ||
| coverage xml | ||
| - name: Upload coverage to Codecov | ||
| if: ${{ !cancelled() }} | ||
| uses: codecov/[email protected] | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| files: coverage.xml | ||
| # make sure no plugins alter our coverage reports | ||
| plugin: noop | ||
| verbose: true | ||
| - name: Upload test results to Codecov | ||
| if: ${{ !cancelled() }} | ||
| uses: codecov/test-results-action@v1 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
| files: .junitxml | ||
| verbose: true | ||
| test-flags-pinned: | ||
| name: Flags (pinned) | ||
| timeout-minutes: 30 | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["3.8","3.12","3.13"] | ||
| python-version: ["3.7","3.8","3.9","3.12","3.13"] | ||
| # python3.6 reached EOL and is no longer being supported on | ||
| # new versions of hosted runners on Github Actions | ||
| # ubuntu-20.04 is the last version that supported python3.6 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the script pull 9.8.0 instead of 9.8.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only considers the highest micro version of each release