ref: Remove SpanKwargs and TransactionKwargs
#4254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
LGTM but mypy is complaining https://github.com/getsentry/sentry-python/actions/runs/14335257636/job/40180557671?pr=4254
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4254 +/- ##
==============================================
- Coverage 83.53% 83.52% -0.01%
==============================================
Files 144 144
Lines 14689 14689
Branches 2328 2328
==============================================
- Hits 12270 12269 -1
Misses 1697 1697
- Partials 722 723 +1
|
These classes were added so that `start_transaction`'s `kwargs` would be typed. Now that that function is deprecated, these classes are no longer needed. The types have also now diverged from the actual signature of `Span.__init__`, making their continued presence confusing
szokeasaurusrex
force-pushed
the
szokeasaurusrex/no-span-kwargs
branch
from
505a921 to
f78c49d
Compare
|
@szokeasaurusrex Can we merge this or do you still want to change anything? |
|
@sentrivana merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes were added so that
start_transaction'skwargswould be typed.Now that that function is deprecated, these classes are no longer needed. The types have also now diverged from the actual signature of
Span.__init__, making their continued presence confusingThank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval.