feat(django): Instrument views as spans #787
Conversation
untitaker
changed the title
| @@ -118,7 +118,7 @@ class Address(Base): | |||
| assert ( | |||
| render_span_tree(event) | |||
| == """\ | |||
| - op=None: description=None | |||
| - op=None: description='None' | |||
There was a problem hiding this comment.
Why op is None and description is 'None'? Other ops below have quotes.
There was a problem hiding this comment.
Hmm maybe None => JSON's null, while the description will always be a string?
There was a problem hiding this comment.
Ah yeah that's an unfortunate side-effect. Will switch to json.dumps as representation method
tests/conftest.py
Outdated
| @@ -334,7 +334,7 @@ def inner(event): | |||
| by_parent.setdefault(span["parent_span_id"], []).append(span) | |||
|
|
|||
| def render_span(span): | |||
| yield "- op={!r}: description={!r}".format( | |||
| yield "- op='{}': description='{}'".format( | |||
There was a problem hiding this comment.
What's the motivation to change this?
There was a problem hiding this comment.
It caused incompatibilities between Python 2 and 3 when rendering unicode strings.
| if integration is None or not integration.middleware_spans: | ||
| return old_resolve(self, path) | ||
|
|
||
| with hub.start_span(op="django.urls.resolve"): |
There was a problem hiding this comment.
I'm not sure this is of much use. If all the resolver does is call the view, isn't it going to be very similar in duration to the django.view span?
There was a problem hiding this comment.
yeah let's remove it. resolver is probably fast enough, usually
This adds spans around URL resolving and the view itself.