Skip to content

Fix for timeout warning parameter for GCP integration & UTC time zone for AWS integration #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2020
Merged

Fix for timeout warning parameter for GCP integration & UTC time zone for AWS integration #799

merged 2 commits into from
Aug 26, 2020

Conversation

shantanu73
Copy link
Contributor

@shantanu73 shantanu73 commented Aug 25, 2020 •
edited by untitaker
Loading

Changes:

  1. Converted local time format to UTC time format for AWS Lambda integration, and verified it on cloudwatch logs.
  2. Added code for timeout_warning parameter in class GcpIntegration.

Fix #796

CHanges:
82f4602 
1) Converted local time format to UTC time format for AWS Lambda integration.
2) Added code for timeout_warning parameter in class GcpIntegration for gcp.py file.
Changes:
6e05a9a 
1) Modified datetime.now() to datetime.utcnow() to include UTC time instead of local time.
@untitaker untitaker merged commit 638a495 into getsentry:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GcpIntegration' object has no attribute 'timeout_warning'
2 participants
@shantanu73 @untitaker