feat: Touch events now track components with sentry-label
#2068
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Support tracking touch events on components with the prop
sentry-label
.Note that this does not throw a typescript error as "it is not a valid JS Identifier"
It will fall back to other properties, with the hierarchy
sentry-label
>accessibilityLabel
>displayName
.Also, removed the tracking of
name
on components without a displayName, found that doing so just caused components to be logged twice.💡 Motivation and Context
Resolves #1913
Likely #950 too
💚 How did you test it?
Tested on sample app, and added unit tests.
📝 Checklist
🔮 Next steps