Skip to content

Add support for ignore_server_port sentry option #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 25, 2019

Conversation

nocive
Copy link
Contributor

@nocive nocive commented Jan 24, 2019

Adds support for the ignore_server_port option supported and documented by sentry.
First time contributing here, so please let me know if I'm missing something.

https://docs.sentry.io/clients/php/config/

ignore_server_port
By default the server port will be added to the logged URL when it is a non standard port (80, 443). Setting this to true will ignore the server port altogether and will result in the server port never getting appended to the logged URL.

@Jean85
Copy link
Contributor

Jean85 commented Jan 24, 2019

There's a single test failing, see https://travis-ci.org/getsentry/sentry-symfony/jobs/483995953#L656

@nocive
Copy link
Contributor Author

nocive commented Jan 25, 2019

@Jean85 Thanks, I had seen it already but didn't have the time to get around to fixing it yesterday. On it 👍

Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jean85 Jean85 merged commit afeec4f into getsentry:master Jan 25, 2019
@nocive
Copy link
Contributor Author

nocive commented Jan 28, 2019

@Jean85 any idea when a new release will be coming? :)

@Jean85
Copy link
Contributor

Jean85 commented Jan 28, 2019

@nocive
Copy link
Contributor Author

nocive commented Jan 28, 2019

Sweet! Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants