Skip to content

Prefer lowest hardening #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2019
Merged

Prefer lowest hardening #194

merged 4 commits into from
Feb 26, 2019

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Feb 25, 2019

During #193 I discovered that we were having issues with the --prefer-lowest CI job. With 855966a I removed some dev deps to lower further, and more issues arose.

This PR will address this.

This is possible since the constraint was introduced in d772535 (#90), but since we no longer use the ExceptionHandler, we're no longer bound to use the ConsoleErrorEvent.
@Jean85 Jean85 added this to the 3.0 (Sentry client 2.0) milestone Feb 25, 2019
@Jean85 Jean85 self-assigned this Feb 25, 2019
@Jean85 Jean85 mentioned this pull request Feb 25, 2019
@Jean85 Jean85 marked this pull request as ready for review February 26, 2019 09:19
@Jean85 Jean85 requested a review from stayallive February 26, 2019 09:19
@Jean85 Jean85 mentioned this pull request Feb 26, 2019
@Jean85 Jean85 merged commit 5ce8775 into master Feb 26, 2019
@Jean85 Jean85 deleted the prefer-dist-hardening branch February 26, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants