Skip to content

Add info about send_default_pii in the upgrade doc #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Jun 13, 2019

In reference to #217 (comment)

@Jean85 Jean85 merged commit b1df97d into master Jun 14, 2019
@Jean85 Jean85 deleted the upgrade-send_default_pii branch June 14, 2019 09:48
@teohhanhui
Copy link
Contributor

teohhanhui commented Sep 12, 2019

I'm using 3.1.0 and it's sending the user's IP address by default. The documentation clearly does not match the actual implementation.

Never mind. I've checked the request, the user's IP address is not being sent, but Sentry fills in the user's IP address using the server IP address (where the PHP process is running). This is really confusing... 😕

@untitaker
Copy link
Member

@teohhanhui i believe this should work better now, let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants