Skip to content

Add php 7.4 in travis #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2019
Merged

Add php 7.4 in travis #282

merged 2 commits into from
Dec 5, 2019

Conversation

Big-Shark
Copy link
Contributor

No description provided.

@Jean85
Copy link
Contributor

Jean85 commented Nov 29, 2019

It's not working yet :( Travis is getting slower and slower at adopting new PHP versions..

@Big-Shark
Copy link
Contributor Author

@Jean85 yeap, I know, but we can wait and restart runner.

Jean85
Jean85 suggested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is still failing due to missing xDebug: https://travis-ci.org/getsentry/sentry-symfony/jobs/618391820#L467-L469

$ phpenv config-rm xdebug.ini

File xdebug.ini does no exist.

The command "phpenv config-rm xdebug.ini" failed and exited with 1 during .

Please add a || echo "Can't disable xDebug along that command to ignore failures

@Big-Shark
Add ignoring error parameter for travis
112bc13 
Travias does not support phpenv config-rm xdebug.ini for php7.4
@Big-Shark
Copy link
Contributor Author

@Jean85 New errors every time

  20x: Function ReflectionType::__toString() is deprecated

    20x in End2EndTest::testGet404 from Sentry\SentryBundle\Test\End2End

The command "vendor/bin/phpunit -v" exited with 1.

Jean85
Jean85 approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures are deprecations that we need to solve with #266 and/or #281. LGTM, thanks!

@Jean85 Jean85 merged commit 578864e into getsentry:master Dec 5, 2019
@Jean85 Jean85 mentioned this pull request Dec 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees

@Big-Shark Big-Shark

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Big-Shark @Jean85