fix PHPUnit 9 deprecations #288
Conversation
There was a problem hiding this comment.
Unfortunately those deprecations are not the cause of the CI failures, but I appreciate them anyway, if they do not make the CI fail under PHP 7.1 (due to PHPUnit 7.5).
OTOH, I do not want to disable the deprecation helper, and those will be fixed by getsentry/sentry-php#930, as said already in #266 (review)
So, please revert the PHPUnit config change. As for PHPStan, I'll take a stab at fixing those issues, I forgot to do it due to the early CI failures.
| @@ -8,6 +8,9 @@ | |||
| cacheResult="false" | |||
| processIsolation="true" | |||
| > | |||
| <php> | |||
| <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak" /> | |||
There was a problem hiding this comment.
Hard failure on Symfony deprecations is required: we cannot let this bundle start them, or we could flood Sentry with unuseful events.
There was a problem hiding this comment.
I was under the assumption that hereby we would ignore the indirect deprecations.
Yes, the direct deprecations on this bundle's code should definitely fail CI. Maybe change the mode then?
After #266 was merged tests still were failing. Found out this was because of deprecation warnings on PHPUnit. This PR fixes these deprecations on the test suite.
PHPStan is the only test that's failing. What about not running PHPStan on the
/testsfolder?