Skip to content

#291 defaulting release config to detected root package version #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2020
Merged

#291 defaulting release config to detected root package version #292

merged 1 commit into from
Jan 3, 2020

Conversation

Ocramius
Copy link
Contributor

@Ocramius Ocramius commented Jan 2, 2020

Effectively automates release tracking for the grand majority of
applications out there, without having to resort to to any VERSION
environment variables nor other custom approaches to be figured out
by the end consumer of the library.

Ref https://docs.sentry.io/workflow/releases/?platform=php

Fixes #291

Effectively automates release tracking for the grand majority of
applications out there, without having to resort to to any `VERSION`
environment variables nor other custom approaches to be figured out
by the end consumer of the library.

Ref https://docs.sentry.io/workflow/releases/?platform=php

Fixes #291
@Ocramius
Copy link
Contributor Author

Ocramius commented Jan 2, 2020

Note: this is a new feature, so 3.3.0 should probably be the target

Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

FTR, the new dependency was already there because it's required already by jean85/pretty-package-versions

@Jean85 Jean85 merged commit c3de3fa into getsentry:master Jan 3, 2020
@Ocramius
Copy link
Contributor Author

Ocramius commented Jan 3, 2020

FTR, the new dependency was already there because it's required already by jean85/pretty-package-versions

Yes, I added it because it is now explicitly referenced in the sources

@Ocramius
Copy link
Contributor Author

Ocramius commented Jan 3, 2020

Thanks for merging, @Jean85! 🎈

Looking forward to the release \o/

@Ocramius Ocramius deleted the feature/#291-automatically-detect-prelease-version branch January 3, 2020 11:57
@Jean85
Copy link
Contributor

Jean85 commented Jan 3, 2020

I cannot release directly, I hope to have it done by next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically detect application release?
2 participants