Explain PsrLogMessageProcessor #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These failures are not related to my work. I guess master is broken. |
|
@guilliamxavier WDYT? Let’s merge it |
|
@ruudk: Maybe -It's recommended to enable `PsrLogMessageProcessor`.
+Additionally, you can register the `PsrLogMessageProcessor` to resolve PSR-3 placeholders in reported messages:Anyway I have no right to approve a PR here (but with the suggested change it would look good to me) |
Jean85
suggested changes
Jan 14, 2020
There was a problem hiding this comment.
Thank you for this PR.
I like @guilliamxavier suggestion very much!
|
@guilliamxavier Would be great to have used the suggest change feature so that I can instantly apply your change. |
|
Feedback applied :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #293 (comment)