Skip to content

Improve class_alias robustness #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ parameters:
-
message: '/Symfony\\Component\\HttpKernel\\Event\\GetResponseForExceptionEvent.$/'
path: src/EventListener/ErrorListener.php
-
message: '/Sentry\\SentryBundle\\EventListener\\RequestListener(Request|Controller)Event( not found)?.$/'
path: src/EventListener/RequestListener.php
-
message: '/Sentry\\SentryBundle\\EventListener\\SubRequestListenerRequestEvent( not found)?.$/'
path: src/EventListener/SubRequestListener.php

includes:
- vendor/jangregor/phpstan-prophecy/src/extension.neon
Expand Down
22 changes: 7 additions & 15 deletions src/EventListener/RequestListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,11 @@
use Symfony\Component\Security\Core\User\UserInterface;

if (Kernel::MAJOR_VERSION >= 5) {
if (! class_exists('Sentry\SentryBundle\EventListener\UserContextRequestEvent')) {
class_alias(RequestEvent::class, 'Sentry\SentryBundle\EventListener\UserContextRequestEvent');
}
if (! class_exists('Sentry\SentryBundle\EventListener\UserContextControllerEvent')) {
class_alias(ControllerEvent::class, 'Sentry\SentryBundle\EventListener\UserContextControllerEvent');
}
class_alias(RequestEvent::class, RequestListenerRequestEvent::class);
class_alias(ControllerEvent::class, RequestListenerControllerEvent::class);
} else {
if (! class_exists('Sentry\SentryBundle\EventListener\UserContextRequestEvent')) {
class_alias(GetResponseEvent::class, 'Sentry\SentryBundle\EventListener\UserContextRequestEvent');
}
if (! class_exists('Sentry\SentryBundle\EventListener\UserContextControllerEvent')) {
class_alias(FilterControllerEvent::class, 'Sentry\SentryBundle\EventListener\UserContextControllerEvent');
}
class_alias(GetResponseEvent::class, RequestListenerRequestEvent::class);
class_alias(FilterControllerEvent::class, RequestListenerControllerEvent::class);
}

/**
Expand Down Expand Up @@ -57,9 +49,9 @@ public function __construct(
/**
* Set the username from the security context by listening on core.request
*
* @param UserContextRequestEvent $event
* @param RequestListenerRequestEvent $event
*/
public function onKernelRequest(UserContextRequestEvent $event): void
public function onKernelRequest(RequestListenerRequestEvent $event): void
{
if (! $event->isMasterRequest()) {
return;
Expand Down Expand Up @@ -94,7 +86,7 @@ public function onKernelRequest(UserContextRequestEvent $event): void
});
}

public function onKernelController(UserContextControllerEvent $event): void
public function onKernelController(RequestListenerControllerEvent $event): void
{
if (! $event->isMasterRequest()) {
return;
Expand Down
12 changes: 4 additions & 8 deletions src/EventListener/SubRequestListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,19 @@
use Symfony\Component\HttpKernel\Kernel;

if (Kernel::MAJOR_VERSION >= 5) {
if (! class_exists('Sentry\SentryBundle\EventListener\UserContextRequestEvent')) {
class_alias(RequestEvent::class, 'Sentry\SentryBundle\EventListener\UserContextRequestEvent');
}
class_alias(RequestEvent::class, SubRequestListenerRequestEvent::class);
} else {
if (! class_exists('Sentry\SentryBundle\EventListener\UserContextRequestEvent')) {
class_alias(GetResponseEvent::class, 'Sentry\SentryBundle\EventListener\UserContextRequestEvent');
}
class_alias(GetResponseEvent::class, SubRequestListenerRequestEvent::class);
}

final class SubRequestListener
{
/**
* Pushes a new {@see Scope} for each SubRequest
*
* @param UserContextRequestEvent $event
* @param SubRequestListenerRequestEvent $event
*/
public function onKernelRequest(UserContextRequestEvent $event): void
public function onKernelRequest(SubRequestListenerRequestEvent $event): void
{
if ($event->isMasterRequest()) {
return;
Expand Down