Skip to content

Add config example for class_serializers #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

Add config example for class_serializers #329

merged 1 commit into from
Apr 9, 2020

Conversation

alexgt9
Copy link
Contributor

@alexgt9 alexgt9 commented Apr 6, 2020

It takes some time for me to guess exactly how to configure class_serializers, errors shown by the compiler aren't beautiful in this case.

Maybe can be useful to add this simple doc for that powerful option.

What do you think?

Jean85
Jean85 suggested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change 👍 I would also add a code example with a class serializer excerpt, so that the explanation is clearer.

@alexgt9 alexgt9 force-pushed the add-class-serializers-docs branch from 8fa7eb8 to e1e83ab Compare April 9, 2020 10:38
@alexgt9
Copy link
Contributor Author

alexgt9 commented Apr 9, 2020

I like this change 👍 I would also add a code example with a class serializer excerpt, so that the explanation is clearer.

Sure! I just added it @Jean85

@Jean85 Jean85 merged commit 6fd935d into getsentry:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexgt9 @Jean85