Make the RequestIntegration integration fetch the request from the request stack #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
suggested changes
Aug 11, 2020
|
@ste93cry should we rebase and merge this? |
|
Yes, I will do it after a few other pending PRs get merged |
Jean85
approved these changes
Jan 4, 2021
ste93cry
deleted the
feature/request-integration-symfony-based-request-fetcher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the
RequestIntegrationintegration now fetches the HTTP request from the request stack of Symfony instead of creating a new request from the PHP superglobals. This should (but I didn't test if it was really broken before) also solve the fact that in the context of a Symfony sub-request the request data attached to the event was referring to the main PHP request