-
Notifications
You must be signed in to change notification settings - Fork 179
Update the dependencies and require the SDK 3.x #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the dependencies and require the SDK 3.x #385
Conversation
After hours and hours of debugging, I found out the cause of the broken build: a change that happened between PHP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine for me; we obviously need to fix the issues in the CI...
I updated the CHANGELOG and added support for a few new options. However, the build on PHP 7.2 keeps failing and I have no idea how to fix it once for all because even if we workaround the issue in the |
As per title, along with a few dependencies (both dev and non) I updated the main SDK to version 3.x 🎉 There weren't many changes to do and the majority were in the tests. In reality, I just made the minimum amount of work to make the tests pass, taking for granted that since both unit and e2e tests are green everything is fine. If someone that is brave enough wants to try this out before merging it it would be really cool