Skip to content

Update the dependencies and require the SDK 3.x #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 17, 2020
Merged

Update the dependencies and require the SDK 3.x #385

merged 9 commits into from
Nov 17, 2020

Conversation

ste93cry
Copy link
Contributor

@ste93cry ste93cry commented Nov 7, 2020

As per title, along with a few dependencies (both dev and non) I updated the main SDK to version 3.x 🎉 There weren't many changes to do and the majority were in the tests. In reality, I just made the minimum amount of work to make the tests pass, taking for granted that since both unit and e2e tests are green everything is fine. If someone that is brave enough wants to try this out before merging it it would be really cool

@ste93cry ste93cry added this to the 4.0 milestone Nov 7, 2020
@ste93cry ste93cry requested a review from Jean85 November 7, 2020 00:37
@ste93cry ste93cry linked an issue Nov 7, 2020 that may be closed by this pull request
@ste93cry
Copy link
Contributor Author

ste93cry commented Nov 7, 2020

After hours and hours of debugging, I found out the cause of the broken build: a change that happened between PHP 7.2 and 7.3 (I didn't find which one) which made sure that when an error is caught in a try statement, error_get_last() is not filled with its information. However, Xdebug maintained this behavior until 2.9.3 when the bug was fixed. Since the FrameContextifierIntegration tries to read a file path which does not exists an exception is thrown and catched, an error is also emitted and as a consequence the rest of the error handling messes up and the test fails. TLDR, Travis CI is using a bugged version of Xdebug for PHP 7.2. I have no clue about why the step with SYMFONY_VERSION=3.4.* SYMFONY_DEPRECATIONS_HELPER=disabled doesn't fail though

https://3v4l.org/Al4QW

@ste93cry ste93cry requested a review from Jean85 November 9, 2020 10:05
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine for me; we obviously need to fix the issues in the CI...

@ste93cry
Copy link
Contributor Author

I updated the CHANGELOG and added support for a few new options. However, the build on PHP 7.2 keeps failing and I have no idea how to fix it once for all because even if we workaround the issue in the FrameContextifierIntegration integration it may arise somewhere else and without changing how we handle the integration of the error handler with the framework I don't see any manouver space

@ste93cry ste93cry requested a review from Jean85 November 16, 2020 19:24
@ste93cry ste93cry requested a review from Jean85 November 16, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sentry-php 3.0
2 participants