-
Notifications
You must be signed in to change notification settings - Fork 179
Support PHP8 and update GitHub Actions. #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change steps priority.
@Jean85 could you check? |
If the issue is the same as in getsentry/sentry-php#1150, PHPStan has troubles running under PHP 8 due to imprecise function signatures. Try to run it under 7.4 for now, I'll run a separate PR to investigate that (and eventually report bugs upstream). As for the CI that is failing, you're tripping over 2 additional errors that are caught by Sentry, and both are reported in the CI. |
@Jean85 What accrued additional problems in the CI - were added Deprecated Message.
|
I've rerun CI on the branch and it's still green: https://github.com/getsentry/sentry-symfony/actions/runs/391772879 Could you please split this PR in two? Reorganization of the actions following Sentry-php repo example is good, but it should be done separately so we can find the root cause of this failures. |
@Jean85 yes, thanks. |
Closing since #399 got the job done. |
No description provided.