Skip to content

Refactor the bundle configuration and add support for XML format #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 2, 2021
Merged

Refactor the bundle configuration and add support for XML format #401

merged 8 commits into from
Jan 2, 2021

Conversation

ste93cry
Copy link
Contributor

With this PR I did a few things, namely:

  • Added support for the XML format to the bundle configuration
  • Refactored the tests to make them more reliable and improved the code to make it simpler and more readable
  • Removed legacy code that was added to support the various features introduced with each 2.x version
  • Refactored how and which container services are registered

@ste93cry ste93cry added this to the 4.0 milestone Dec 18, 2020
@ste93cry ste93cry requested a review from Jean85 December 18, 2020 21:00
Jean85
Jean85 reviewed Dec 19, 2020
View reviewed changes
Copy link
Contributor

@Jean85 Jean85 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a first glance, this LGTM, but I need to delve a little more locally, with an IDE.

Unfortunately, the build is still having issues, and I'm making no progress on #400 😢

@ste93cry
Copy link
Contributor Author

Unfortunately, the build is still having issues, and I'm making no progress on #400 😢

Yep I know, some failures of this build are not related to the broken CI anyway. I'm working to fix as much as I can and then I will take a look at the rest. Since the last commit on master is green, something must have changed in the last few versions of PHPStan

Jean85
Jean85 suggested changes Dec 22, 2020
View reviewed changes
@ste93cry ste93cry requested a review from Jean85 December 25, 2020 19:43
Jean85
Jean85 suggested changes Dec 27, 2020
View reviewed changes
@ste93cry ste93cry requested a review from Jean85 December 28, 2020 12:36
ste93cry
ste93cry commented Dec 28, 2020
View reviewed changes
@Jean85 Jean85 merged commit c95a2bd into getsentry:master Jan 2, 2021
@ste93cry ste93cry deleted the feature/refactor-bundle-config-tree branch January 2, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
Feature Improvement
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ste93cry @Jean85