Skip to content

Test messenger configuration #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2021
Merged

Test messenger configuration #420

merged 1 commit into from
Jan 22, 2021

Conversation

dragosprotung
Copy link
Contributor

Follow up #417

@dragosprotung dragosprotung mentioned this pull request Jan 21, 2021
Merged
@ste93cry ste93cry added this to the 4.0 milestone Jan 21, 2021
ste93cry
ste93cry suggested changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the option to the DependencyInjection/Fixtures/xml/full.xml file rather than to the one you changed and set its value to false so that in the tests it gets asserted that it is parsed correctly?

@dragosprotung dragosprotung changed the title Test option Test messenger configuration Jan 22, 2021
@dragosprotung
Copy link
Contributor Author

Added test config for all other formats as well

ste93cry
ste93cry approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@ste93cry ste93cry merged commit ed64c02 into getsentry:master Jan 22, 2021
@dragosprotung dragosprotung deleted the patch-1 branch January 22, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ste93cry ste93cry ste93cry approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dragosprotung @ste93cry