Fix regression that send PII even when the send_default_pii option is off #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
changed the title
ste93cry
force-pushed
the
fix-regression-with-pii-sent-regardless-of-option-value
branch
from
d2765a7 to
8d1b9ca
Compare
Jean85
approved these changes
Jan 22, 2021
Jean85
deleted the
fix-regression-with-pii-sent-regardless-of-option-value
branch
Jean85
pushed a commit
to rjd22/sentry-symfony
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #422: basically, during the refactoring of the
RequestListenerclass that I did in #387 I forgot to consider thesend_default_piioption when capturing the user data (IP address and username).