Allow explicit null value for dsn configuration option #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvandevijver
force-pushed
the
patch-1
branch
2 times, most recently
from
3082cfa to
0cd738a
Compare
Jean85
suggested changes
Mar 3, 2021
|
@Jean85 I tried to make something fitting. I added tests for three supported falsy values (according to the https://github.com/getsentry/sentry-php/blob/master/src/Options.php#L822). Both the |
Jean85
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #454 missed this particular line: when the
dsnconfiguration option was set tonull, it was still not forwarded to the actual Sentry options.Setting it to an empty string does work in 4.0.2, so that can be used as temporary workaround.