Fix failing unit tests after Symfony issue #38019 bugfix #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
suggested changes
Mar 7, 2021
|
Yes I know, the bug is being investigated in symfony/symfony#40390 |
|
Issue seems to have been fixed with symfony/symfony#40494, should we wait for a tag? |
|
Yes, I talked privately with Nicolas and he said me that the new version should be released before the end of the month. The alternative in the meantime would be to fix the |
|
Roger. We need to keep in mind that this same problem is breaking the CI in 3.5.x too, where we have a couple of PR to release as a patch. |
|
Symfony |
…lling bugged version
Jean85
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for the
TracingRequestListenerclass are failing after the release of the fix for symfony/symfony#38019. Since PHP 5.4, theREQUEST_TIME_FLOATelement is always present in$_SERVER, but Symfony was not setting the value when creating the request object manually, therefore we had to do it ourselves. Now that this is unnecessary, we can cleanup the code