Fix the conditions to automatically enable the tracing of the cache adapters #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
force-pushed
the
fix-cache-tracing-auto-enabling-conditions
branch
from
ab091cb to
ad14692
Compare
Jean85
reviewed
Apr 21, 2021
Jean85
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized that relying on the presence of the
CacheInterfaceinterface from thesymfony/cache-contractspackage is wrong because older versions of the Cache component (e.g.3.4.x) does not depend from it and therefore the tracing instrumentation is not activated automatically as expected.