Fix deprecations triggered by Symfony 5.3 #489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
suggested changes
Apr 26, 2021
derrabus
force-pushed
the
bugfix/symfony-5.3
branch
from
1c4d2e4 to
82e3067
Compare
derrabus
force-pushed
the
bugfix/symfony-5.3
branch
from
82e3067 to
bad25a7
Compare
|
Done! I noticed that some of my changes could also be applied to the 3.5.x branch. Is that branch still open for this kind of fixes? Would it make sense to fix that branch first then? |
Yes it is, if you have time to contribute also to that version it would be awesome. Unfortunately we cannot merge the two branches because the code is foundamentally different and so we have to backport each commit/PR manually |
ste93cry
approved these changes
Apr 26, 2021
|
Done in #490. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes deprecation warnings from the upcoming Symfony 5.3 release:
UserInterfacemust provide agetUserIdentifier()method now.