Add bus, receiver and message name to extra's #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
suggested changes
Apr 28, 2021
katchmk
commented
Apr 28, 2021
|
Are you willing to finish the implementation or is this PR abandoned? |
|
Not abandoned. Did I miss any of your feedback? I thought I applied it all. |
ste93cry
suggested changes
May 11, 2021
There was a problem hiding this comment.
I see there is still some commented code here and there, and I don't understand why you switched from captureException() to captureEvent(). I mentioned the latter in #492 (comment) just for the sake of the example, I didn't mean you to change it
|
I took the time to finish this PR as I would really love to see it merged. Hopefully you don't mind I rebased the branch and pushed some changes to your code. It would be great if you could test it out before I give the final approval to be sure everything works as expected |
Jean85
approved these changes
Jul 27, 2021
ste93cry
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
With this PR we can send extra information about the worker like busName, receiver, and the actual message object name.
In the future (when I have more time) we can add configuration for custom stamps to be sent along.