Fix fatal error when the SERVER_PROTOCOL header is missing
#495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
force-pushed
the
fix-crash-on-missing-server-protocol-header
branch
from
0deb6e5 to
35ac9a2
Compare
ste93cry
force-pushed
the
fix-crash-on-missing-server-protocol-header
branch
from
35ac9a2 to
16f1d5c
Compare
Jean85
approved these changes
May 5, 2021
derrabus
added a commit
to symfony/symfony
that referenced
this pull request
May 5, 2021
…null (Jean85) This PR was merged into the 4.4 branch. Discussion ---------- [HttpFoundation] Request::getProtocolVersion may return null | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT This is just a minor PHPDoc fix, but we stumbled on it in getsentry/sentry-symfony#495, and static analysis complains about our fix. Basically, `SERVER_PROTOCOL` may not be set, even if it shouldn't be missing according to [RFC 3875 (GCI spec)](https://tools.ietf.org/html/rfc3875#section-4.1.16). In our case, the user reported the issue because the request was issued interally by a pod health check inside Kubernetes. Commits ------- 99aadb3 getProtocolVersion may return null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, fixes #494. It should not happen since the
SERVER_PROTOCOLheader must be present according to RFC 3875 (GCI spec), but in cases when it's mistakenly missing better be safe than sorry