Skip to content

Add the sentry_trace_meta() Twig function to print the sentry-trace HTML meta tag #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ste93cry
Copy link
Contributor

As per title, fixes #458 by adding the sentry_trace_meta() Twig function. Unlike the Laravel's SDK, I decided to always print the HTML meta tag regardless of whether a transaction/span is active because I like to be consistent in the expected output and because there should be no issue in having a blank string as its content

@ste93cry ste93cry added this to the 4.2 milestone May 19, 2021
@ste93cry ste93cry requested a review from Jean85 May 19, 2021 11:55
@ste93cry ste93cry force-pushed the feature/twig-function-to-print-sentry-trace-meta-tag branch from ade4687 to b41dc56 Compare May 19, 2021 12:00
@ste93cry ste93cry requested a review from Jean85 May 19, 2021 16:39
@Jean85 Jean85 merged commit 6576e11 into develop May 20, 2021
@Jean85 Jean85 deleted the feature/twig-function-to-print-sentry-trace-meta-tag branch May 20, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants