Skip to content

Add accessor for wrapped DBAL Connection to TracingDriverConnection #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jul 15, 2021

Allows accessing e.g. underlying PDO instance so reflection does not have to be used for that.

Mimics DBAL's `Connection::getWrappedConnection()`` https://github.com/doctrine/dbal/blob/25496429ef4bba2352b0ced7daffe1b3dec83d13/src/Connection.php#L1518-L1525

Resolves #522

Copy link
Contributor

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a CHANGELOG entry referring to this PR and switch the base branch to develop?

Allows accessing e.g. underlying PDO instance so reflection does not have to be used for that.

Mimics DBAL's `Connection::getWrappedConnection()`` https://github.com/doctrine/dbal/blob/25496429ef4bba2352b0ced7daffe1b3dec83d13/src/Connection.php#L1518-L1525
@simPod simPod changed the base branch from master to develop July 15, 2021 08:06
Copy link
Contributor

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@ste93cry ste93cry merged commit 95e0d62 into getsentry:develop Jul 15, 2021
@simPod
Copy link
Contributor Author

simPod commented Jul 15, 2021

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to get decorated connection
2 participants