fix(types): added nullability to getDatabase method #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If getDatabase doesn't allow null return values, it will fail when the Driver returns null for this method. It happens in https://github.com/webmozart/doctrine-dbal/blob/master/lib/Doctrine/DBAL/Driver/PDOSqlite/Driver.php#L114 when using `DATABASE_URL="sqlite:///:memory:"` this is weird because in-memory dbs are usually used in a test environments were sentry is deactivated, but this class is still being loaded and throws errors in all the tests. I get the following error in all the tests: `TypeError : Return value of Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriver::getDatabase() must be of the type string, null returned` with this change it works for me.
|
Thank you for catching this bug, I just had a look at the PHPDoc of that method and it doesn't mention |
sure |
ste93cry
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If getDatabase doesn't allow null return values, it will fail when the Driver returns null for this method.
It happens in https://github.com/webmozart/doctrine-dbal/blob/master/lib/Doctrine/DBAL/Driver/PDOSqlite/Driver.php#L114 when using
DATABASE_URL="sqlite:///:memory:"this is weird because in-memory dbs are usually used in a test environments were sentry is deactivated, but this class is still being loaded and throws errors in all the tests.
I get the following error in all the tests:
TypeError : Return value of Sentry\SentryBundle\Tracing\Doctrine\DBAL\TracingDriver::getDatabase() must be of the type string, null returnedwith this change it works for me.