Fix missing instrumentation of the Statement::execute() method of Doctrine DBAL

[ste93cry]

Fixes #544: thanks to @jokaorgua I found out that the Doctrine\DBAL\Driver\Statement::execute() method has to be instrumented as well for the tracing of SQL queries to work properly in case a prepared statement is used, e.g. when calling the Doctrine\DBAL\Connection::fetch*() methods and passing some query params to them. I voluntarily avoided a child span for the TracingStatement::execute() method because you may prepare a query and run it later, so it doesn't make sense to have it nested into the one of the TracingDriverConnection::prepare() method as it would have happened by creating it inside the callback of the TracingDriverConnection::traceFunction() function

[Jean85]

This seems a bit complicated, but we don't have any other way around it...

[jokaorgua]

@ste93cry could you please fix the phpstan errors? seems to me these errors hold the pull request to be merged and a new version released

[Jean85]

@jokaorgua we're still having issues in solving this. PHPStan doesn't seem to be able to overcome the fact that we're conditionally declaring a class, so it stumbles on the incompatible interface.

We haven't still found a way around it.

[ste93cry]

That's right, but the solution to solve those errors is to ignore analysis for entire files because PHPStan crash badly otherwise, which imho it shouldn't. I'm investigating if there is any solution or if reporting the issue upstream would be acceptable

[Jean85]

Finally, it's green!!

[ste93cry]

@jokaorgua before we get this released, likely next week, can you please try it out and see if everything works as expected?

[jokaorgua]

@jokaorgua before we get this released, likely next week, can you please try it out and see if everything works as expected?

will do. once checked will make a comment here

[jokaorgua]

@ste93cry everything is ok. I see sql.stmt.execute row