Skip to content

Add missing return type hints to the methods of the SentryExtension class #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2021
Merged

Add missing return type hints to the methods of the SentryExtension class #563

merged 3 commits into from
Oct 5, 2021

Conversation

eerison
Copy link
Contributor

@eerison eerison commented Oct 4, 2021 •
edited
Loading

I'm testing symfony 5.4-dev and I'm getting few warning related with sentry-symfony

Screenshot 2021-10-04 at 13 48 37

@eerison eerison changed the title maintenance/add-type-hin-in-sentry-extension maintenance/add-type-hint-in-sentry-extension Oct 4, 2021
Jean85
Jean85 suggested changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

I tried to get them to pop up using the ErrorHandler component but it didn't mark anything, so thank you for spotting it!

Can you add a changelog entry too please?

@Jean85 Jean85 added this to the 4.2 milestone Oct 4, 2021
@eerison eerison force-pushed the maintanance/add-type-hint-in-sentry-extension branch from 75a6226 to 58824c5 Compare October 4, 2021 15:35
@eerison eerison requested a review from Jean85 October 4, 2021 15:36
@eerison
Copy link
Contributor Author

eerison commented Oct 4, 2021

Thank you for your contribution!

I tried to get them to pop up using the ErrorHandler component but it didn't mark anything, so thank you for spotting it!

Can you add a changelog entry too please?

Hi @Jean85 I added the changelog could you check again please :)

Jean85
Jean85 suggested changes Oct 4, 2021
View reviewed changes
@eerison @Jean85
Update CHANGELOG.md
cd9b0c2 
Co-authored-by: Alessandro Lai <[email protected]>
@eerison eerison requested a review from Jean85 October 4, 2021 15:51
@ste93cry ste93cry changed the title maintenance/add-type-hint-in-sentry-extension Add missing return type hints to the methods of the SentryExtension class Oct 4, 2021
ste93cry
ste93cry suggested changes Oct 4, 2021
View reviewed changes
@eerison @ste93cry
Update CHANGELOG.md
0c0ca3b 
Co-authored-by: Stefano Arlandini <[email protected]>
@eerison eerison requested a review from ste93cry October 4, 2021 17:17
ste93cry
ste93cry approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Jean85 Jean85 merged commit be9b065 into getsentry:master Oct 5, 2021
@eerison eerison deleted the maintanance/add-type-hint-in-sentry-extension branch October 5, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ste93cry ste93cry ste93cry approved these changes

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@eerison @ste93cry @Jean85