Fix error when no clientIp exists #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93cry
suggested changes
Oct 10, 2021
There was a problem hiding this comment.
Can you please add a CHANGELOG entry referring this PR and a new test case to the RequestListenerTest::handleKernelRequestEventForSymfonyVersionAtLeast43DataProvider() method to prevent a possible regression in the future?
alexander-schranz
force-pushed
the
bugfix/user-data
branch
from
4b8cbc1 to
348cb9f
Compare
alexander-schranz
force-pushed
the
bugfix/user-data
branch
from
348cb9f to
66ac3cc
Compare
ste93cry
suggested changes
Oct 11, 2021
Co-authored-by: Stefano Arlandini <[email protected]>
|
PR updated. |
|
The PHP |
|
Thx I updated i from main to master request. |
Jean85
approved these changes
Oct 11, 2021
ste93cry
approved these changes
Oct 11, 2021
|
Thx for merging. Do you know if there is any release planned? |
|
There is no plan, we release new versions as needed. I think that a good ETA for the next patch could be the next week as I have one more thing that I would like to fix before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getClientIP()can return null and so it will error when usingcreateFromUserIpAddressinstead we creating an instance manually and use the nullablesetIpAddressmethod.