test against different dependency versions #58
Conversation
xabbuh
commented
May 18, 2017
xabbuh
commented
- by default, run with latest stable versions
- add a job with lowest stable constrained deps
- run with upcoming releases of required deps
* by default, run with latest stable versions * add a job with lowest stable constrained deps * run with upcoming releases of required deps
xabbuh
force-pushed
the
explicit-requirements
branch
from
70b8719 to
d5690af
Compare
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "friendsofphp/php-cs-fixer": "^1.8.0", | ||
| "phpunit/phpunit": "^4.6.6" | ||
| }, | ||
| "minimum-stability": "dev", |
There was a problem hiding this comment.
I don't like the addition of this. I know that this is needed for testing against Symfony 4, but in this way it will allow the installation of a lot of dependencies as dev-master, which could cause a lot of unrelated failures in the build (see this build).
Could we allow SF 4.0 in some other way, like "^2.4|^3.0|^4.0|^4.0-dev"?
There was a problem hiding this comment.
Sure, that would work. Though I think it would be a good idea to run a dedicated job with dev versions of all required dependencies. Hopefully, this helps spotting issues before new releases of required packages are released. Also note that by default no untagged deps will be installed due to the usage of the --prefer-stable option but only one job is leveraging this setting. However, if you are not happy with this change, I will of course update the required version instead. :)
There was a problem hiding this comment.
Yes I will prefer that, thanks. I've noticed that the --prefer-stable avoids untagged releases, but the issue that I was highlighting is on the matrix element that you added, where that flag is not used. Also, declaring that this lib is 4.0-compatible is kind of a lie right now, since it's not released and it can change and have BC at any time now. And if we tag a release with this in the composer.json it could create problems in the future, with Composer rolling back to that version because of that.
There was a problem hiding this comment.
Alright, I removed the ^4.0 part of the constraint and removed the minimum-stability setting alongside the unstable build job.
Depending on the FrameworkBundle implicitly pulling into all the required packages is fragile and likely to break.
xabbuh
force-pushed
the
explicit-requirements
branch
from
adbf6f1 to
c23fa89
Compare
|
Thanks @xabbuh! I've pushed an other commit on top to simplify the options ( [EDIT] Damn, we are not really compatible with SF 2.4, the lowest is failing! |
Since #58 I discovered that we do not really support Symfony <2.7, since TokenStorageInterface and AuthorizationCheckerInterface were implemented later than 2.4, in 2.6. Since 2.6 and previous versions are now no longer supported, it makes sense to bump to the oldest currently supported version.
