Support http_connect_timeout and http_timeout options #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
suggested changes
Jan 19, 2022
There was a problem hiding this comment.
This needs:
- to lock against
sentry/sentrywhich includes Support http_connect_timeout and http_timeout options sentry-php#1282 (probably^3.4?) - a changelog entry
- additions to the tests that cover the configuration
Jean85
suggested changes
Jan 20, 2022
This comment was marked as outdated.
This comment was marked as outdated.
|
Build restarted, we have Psalm and a couple of other jobs failing. |
ste93cry
approved these changes
May 29, 2022
Jean85
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I raised this issue: #592
This PR adds the ability to set options for http (timeout) options, when paired with getsentry/sentry-php#1282 (which modifies the
sentry-phpSDK) will allow the setting of these options via Symfony yml configuration.Example use:
sentry.yml:If I've missed the mark, feel free to reject - I'd just love to be able to do this in my app, if it's possible already please let me know, thanks!