fix: Make getTraceMeta() function public. #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
suggested changes
May 16, 2022
|
Are we really sure that this is not a bug in Twig itself? I mean, it worked fine until now, and suddenly a minor version is released and it breaks everything: it's weird... |
|
It seems related to twigphp/Twig#3702 We can try to report it as it is to see if they want to fix it or not. |
Jean85
suggested changes
May 16, 2022
There was a problem hiding this comment.
Stof suggested to us to switch to the more direct public method way (so with [$this, 'methodName]) since it would be more performant under Twig: twigphp/Twig#3703 (comment)
|
PR updated with the direct method call. Do I need to rebase? |
Jean85
approved these changes
May 16, 2022
ste93cry
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #627