Skip to content

Start development of version 4.4.x #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2022
Merged

Start development of version 4.4.x #639

merged 1 commit into from
Jun 1, 2022

Conversation

ste93cry
Copy link
Contributor

No description provided.

@ste93cry ste93cry added this to the 4.4 milestone May 31, 2022
@ste93cry ste93cry requested a review from Jean85 May 31, 2022 16:27
@ste93cry ste93cry changed the base branch from master to develop May 31, 2022 16:27
Jean85
Jean85 suggested changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand... Shouldn't we set dev-develop as 4.4?

@ste93cry
Copy link
Contributor Author

ste93cry commented Jun 1, 2022

In the past we used to do it, but a lot of time passed since the last time. I don't remember where, but I read somewhere that regardless of the branch, you should always use dev-master

@Jean85
Copy link
Contributor

Jean85 commented Jun 1, 2022

I'm not against using dev-master, but it should alias to 4.3, while dev-develop should alias to 4.4.

Jean85
Jean85 approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I misread the target of the PR.

@ste93cry ste93cry merged commit 5aaee42 into getsentry:develop Jun 1, 2022
@ste93cry ste93cry deleted the start-version-4.4-development branch June 1, 2022 19:29
alekitto pushed a commit to alekitto/sentry-symfony that referenced this pull request Jul 5, 2022
@ste93cry @alekitto
Start development of version 4.4.x (getsentry#639)
6be83cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ste93cry @Jean85