Skip to content

Listens on console.command to trigger client load #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2017
Merged

Listens on console.command to trigger client load #67

merged 1 commit into from
Jul 27, 2017

Conversation

rdohms
Copy link
Contributor

@rdohms rdohms commented Jul 24, 2017

Closes #66.

This hook up forces the boot of the client to happen always when a command is triggered, which before only happened if an exception was thrown.

This should offer no BC issues and the only side effect is catching more notices then before as these may have been going unnoticed.

@rdohms
Listens on console.command to trigger client load
cc98155 
Closes getsentry#66. This hook up forces the boot of the client to happen always
when a command is triggered, which before only happened if an exception
was thrown.
Jean85
Jean85 approved these changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have liked an integration test to verify this use case, but unfortunately we do not have anything ready for that. I'll think about it in the future.

@Jean85
Copy link
Contributor

Jean85 commented Jul 27, 2017

Thanks for the contribution @rdohms !! I'll try to release this in a patch ASAP.

@Jean85 Jean85 merged commit ea4cf23 into getsentry:master Jul 27, 2017
@rdohms rdohms deleted the 66/console-hook-in branch July 27, 2017 09:38
@lcobucci
Copy link

@Jean85 I think that something weird happened, this commit is not part of v0.8.1: https://github.com/getsentry/sentry-symfony/commits/0.8.1

Jean85 pushed a commit that referenced this pull request Jul 28, 2017
@rdohms @Jean85
Cherry picked from commit cc98155 to merge #67
ced72a0
@Jean85
Copy link
Contributor

Jean85 commented Jul 28, 2017

@lcobucci @rdohms my bad, I handled badly the fact that this PR was targeting master and not the 0.8.x branch. I've now cherrypicked the commit and tagged a 0.8.2 release wich should be fixed.

@lcobucci
Copy link

@Jean85 no worries, it happens. Thanks!

@Jean85 Jean85 modified the milestone: Stable release 1.0 Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Stable release 1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rdohms @Jean85 @lcobucci