-
Notifications
You must be signed in to change notification settings - Fork 179
Add handled/unhandled exception support #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handled/unhandled exception support #674
Conversation
defc885
to
45a7c8c
Compare
Need a bit of direction, right now this supports pre 3.11.0 versions of the SDK, I can either:
|
Thanks for the contribution. I can release a new version of |
7404176
to
26a4b44
Compare
Cool stuff!
|
I looked at this but didn't see anywhere obvious to put such a helper, I figured ideally the |
Due to our Unified API, we can't add functions to the Hub that easily. |
a458d86
to
2530929
Compare
Update hopefully it passes - all fine locally apart from Psalm which seems to be emitting nonsense errors. 😖 |
2530929
to
b2530c9
Compare
b2530c9
to
1acc6a8
Compare
@cleptric I've updated this again. |
@cleptric not sure how I can fix the failing code coverage thing, seems to be missing coverage on parenthesis? |
@cs278 No worries, this is fine. I'll need to test the message stuff, but I'm currently busy with other things. |
@cleptric polite request for an update. I'm ready to ship changes ditching our custom Sentry 1 Symfony integration and this is the only roadblock left in the way. |
I'm still focusing on other SDKs at the moment. Can't really give you a timeline, sorry 😕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your work on this and sorry for the delay 🙂
LGTM! 🚢
Fixes #670
Requires: getsentry/sentry-php#1430