-
Notifications
You must be signed in to change notification settings - Fork 179
Add a register_error_handler
config option
#687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a register_error_handler
config option
#687
Conversation
@@ -111,9 +112,9 @@ private function registerConfiguration(ContainerBuilder $container, array $confi | |||
}, $options['class_serializers']); | |||
} | |||
|
|||
if (isset($options['integrations'])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isset
was unnecessary since the configuration always returns an array.
b19b8c4
to
4b26934
Compare
Thanks for the contribution! I'll take a look in January, as we're wrapping up things for this year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this LGTM! Thanks for your work on this 🙂
FYI, I've opened a PR for this option in the Symfony recipes repo symfony/recipes-contrib#1485 |
My second attempt at getsentry/sentry-php#1439 .
Pretty much what was described in #337 (comment) , eg: