Skip to content

Fix readme options error_types that expected array #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JellyBellyDev
Copy link

see title of PR.

@Jean85
Copy link
Contributor

Jean85 commented Aug 24, 2017

Well, that was unexpected, thanks for noticing!

I assume you got that because you needed it and found the discrepancy: can you first report back if this seems to work?
I don't like that it is like this, but changing this now would mean a BC; your PR could be still valid, but I would like to change it in the stable release.

@Jean85 Jean85 self-assigned this Aug 24, 2017
@JellyBellyDev
Copy link
Author

In the previous release version (before you move options and set deprecated level config), this parameter should have a string value, in the new version it wants it as an array.

Maybe the bug is here and not should continue to be a array but a string?

@JellyBellyDev
Copy link
Author

However changing the configuration as reported in my readme works!

@Jean85
Copy link
Contributor

Jean85 commented Aug 24, 2017

Well, then it's a bug!! I'll fix it right away, thanks for spotting it!

@Jean85 Jean85 closed this Aug 24, 2017
@JellyBellyDev
Copy link
Author

Happy to have been of help!

@Jean85
Copy link
Contributor

Jean85 commented Aug 24, 2017

I've released a patch: https://github.com/getsentry/sentry-symfony/releases/tag/0.8.6
You're highly advised on updating to it; I'll get on working on the stable release ASAP, which will drop all this options-related nonsense.

@JellyBellyDev
Copy link
Author

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants