Fix Error when using a no authenticated token #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thanks for the contribution. The tests are now broken, can you fix that? |
|
I'll fix tests tonight |
|
@Jean85 tests pass |
Jean85
approved these changes
Oct 23, 2017
|
Thanks for the contribution! I will add a regression test and the changelog info after merging. |
|
Thanks too, can you publish a release after merging ? |
|
I need to backport this to the 0.8 release too, the master branch is currently for the future 1.0 release. |
Jean85
added a commit
that referenced
this pull request
Oct 23, 2017
Jean85
pushed a commit
that referenced
this pull request
Oct 23, 2017
Jean85
added a commit
that referenced
this pull request
Oct 23, 2017
(cherry picked from commit e538969)
Jean85
added a commit
that referenced
this pull request
Oct 23, 2017
Jean85
added a commit
that referenced
this pull request
Oct 23, 2017
|
Released as 0.8.7 |
Jean85
added a commit
that referenced
this pull request
Oct 24, 2017
Add regression test and changelog entry about #78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this lib https://github.com/rezzza/SecurityBundle (for private api acces with signature security)
it create a specific token that not belongs to an user & not declare an authentication provider for it.
when sentry try to call isGranted sf want the user & call all auth providers, etc.