Skip to content

fix: Vulkan shader gen binary path when not cross compiling #11149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Vulkan shader gen binary path when not cross compiling #11149

wants to merge 1 commit into from

Conversation

giladgd
Copy link
Contributor

@giladgd giladgd commented Jan 8, 2025

@github-actions github-actions bot added Vulkan Issues specific to the Vulkan backend ggml changes relating to the ggml tensor library for machine learning labels Jan 8, 2025
@giladgd
Copy link
Contributor Author

giladgd commented Jan 8, 2025

@ag2s20150909 Can you please check that this fix doesn't reintroduce the issue you were having with cross-compiling Vulkan?

@giladgd giladgd mentioned this pull request Jan 8, 2025
Merged
@bandoti
Copy link
Collaborator

bandoti commented Jan 9, 2025

I don't think we need this PR after thinking about it more. The real problem we're dealing with is that when cross-compiling, vulkan-shaders-gen needs to be built using the build-system compiler. This PR does not address that and what we really need is to wrap up #10448! I will take a look at the node-llama-cpp setup and see if I have any issues.

@giladgd
Copy link
Contributor Author

giladgd commented Jan 9, 2025

@bandoti I agree.

@giladgd giladgd closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ggml changes relating to the ggml tensor library for machine learning Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giladgd @bandoti