Skip to content

llama : remove 'd' from bad special token log #11212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

danbev
Copy link
Collaborator

@danbev danbev commented Jan 13, 2025

This commit removes the 'd' from the log message in llama-vocab.cpp when logging a bad special token.

The motivation for this is that currently the output can look something like the following:

load: bad special token: 'tokenizer.ggml.image_token_id' = 128256d, using default id -1

This commit removes the 'd' from the log message in llama-vocab.cpp
when logging a bad special token.

The motivation for this is that currently the output can look something
like the following:
```console
load: bad special token:
    'tokenizer.ggml.image_token_id' = 128256d, using default id -1
```
@danbev danbev merged commit 8f70fc3 into ggml-org:master Jan 13, 2025
48 checks passed
@danbev danbev deleted the vocab-special-token-warn branch February 5, 2025 05:02
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
This commit removes the 'd' from the log message in llama-vocab.cpp
when logging a bad special token.

The motivation for this is that currently the output can look something
like the following:
```console
load: bad special token:
    'tokenizer.ggml.image_token_id' = 128256d, using default id -1
```
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
This commit removes the 'd' from the log message in llama-vocab.cpp
when logging a bad special token.

The motivation for this is that currently the output can look something
like the following:
```console
load: bad special token:
    'tokenizer.ggml.image_token_id' = 128256d, using default id -1
```
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
This commit removes the 'd' from the log message in llama-vocab.cpp
when logging a bad special token.

The motivation for this is that currently the output can look something
like the following:
```console
load: bad special token:
    'tokenizer.ggml.image_token_id' = 128256d, using default id -1
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants