Skip to content

common: utils to split / join / repeat strings (from json converter) #11342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

ochafik
Copy link
Collaborator

@ochafik ochafik commented Jan 22, 2025

Simple string helpers + tiny refactoring of schema converter w/ a builder.

Extracted from #9639

@ochafik ochafik changed the title common: string utils for split / join / repeat (from json converter) common: utils to split / join / repeat strings (from json converter) Jan 22, 2025
@ochafik ochafik changed the title common: utils to split / join / repeat strings (from json converter) common: utils to split / join / repeat strings (from json converter) Jan 22, 2025
@ochafik ochafik marked this pull request as ready for review January 22, 2025 02:41
@ochafik ochafik merged commit a94f3b2 into ggml-org:master Jan 22, 2025
45 checks passed
anagri pushed a commit to BodhiSearch/llama.cpp that referenced this pull request Jan 26, 2025
ggml-org#11342)

* Factor string_join, string_split, string_repeat into common

* json: refactor to surface a versatile builder

* Update common.cpp
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
ggml-org#11342)

* Factor string_join, string_split, string_repeat into common

* json: refactor to surface a versatile builder

* Update common.cpp
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
ggml-org#11342)

* Factor string_join, string_split, string_repeat into common

* json: refactor to surface a versatile builder

* Update common.cpp
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
ggml-org#11342)

* Factor string_join, string_split, string_repeat into common

* json: refactor to surface a versatile builder

* Update common.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants