Skip to content

server: fix stop regression #11543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

server: fix stop regression #11543

merged 1 commit into from
Jan 31, 2025

Conversation

ochafik
Copy link
Collaborator

@ochafik ochafik commented Jan 31, 2025

Revert changes done to find_partial_stop_string in #9639

Fixes #11538 (cc/ @matteoserva)

@ochafik ochafik added the bugfix fixes an issue or bug label Jan 31, 2025
@ochafik ochafik marked this pull request as ready for review January 31, 2025 12:33
@ochafik ochafik requested a review from ngxson as a code owner January 31, 2025 12:33
@ochafik ochafik requested a review from ggerganov January 31, 2025 12:33
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - what is the difference between the 2 versions and why the new one fails?

@ochafik ochafik closed this Jan 31, 2025
@ochafik ochafik reopened this Jan 31, 2025
@ochafik ochafik merged commit b1bcd30 into ggml-org:master Jan 31, 2025
53 of 54 checks passed
@ochafik
Copy link
Collaborator Author

ochafik commented Jan 31, 2025

Just curious - what is the difference between the 2 versions and why the new one fails?

@ggerganov It had a silly while where it needed an if, and if failed to find " O" in "O P Q" like the old version does.

tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes an issue or bug examples server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc. bug: llama-server ignores the stop parameter
2 participants