HIP: add GGML_CUDA_CC_IS_* macros for testing for amd architeure familys #11601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…res for amd gpus are not supersets of eatch other This fixes a bug where RDNA1 gpus other than gfx1010 where not handled corectly
github-actions
bot
added
Nvidia GPU
JohannesGaessler
approved these changes
Feb 2, 2025
tinglou
pushed a commit
to tinglou/llama.cpp
that referenced
this pull request
Feb 13, 2025
…res for amd gpus are not supersets of eatch other (ggml-org#11601) This fixes a bug where RDNA1 gpus other than gfx1010 where not handled correctly
orca-zhang
pushed a commit
to orca-zhang/llama.cpp
that referenced
this pull request
Feb 26, 2025
…res for amd gpus are not supersets of eatch other (ggml-org#11601) This fixes a bug where RDNA1 gpus other than gfx1010 where not handled correctly
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
…res for amd gpus are not supersets of eatch other (ggml-org#11601) This fixes a bug where RDNA1 gpus other than gfx1010 where not handled correctly
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
…res for amd gpus are not supersets of eatch other (ggml-org#11601) This fixes a bug where RDNA1 gpus other than gfx1010 where not handled correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For amd devices, increasing cc architectures are not supersets of eatch other causing the use of checks against cc to be bug prone
This fixes a bug where RDNA1 gpus other than gfx1010 where not handled correctly.
The GGML_CUDA_CC_IS_ macros are way less bug prone as they mirror the #if defined(CDNA) etc checks we do in device code.